Check explicit indexes when comparing two xarray objects
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
Is your feature request related to a problem? Please describe.
With the explicit index refactor, two Dataset or DataArray objects a and b may have the same variables / coordinates and attributes but different indexes.
Describe the solution you'd like
I'd suggest that a.identical(b) by default also checks for equality betweena.xindexes and b.xindexes.
One drawback is when we want to check either the attributes or the indexes but not both. Should we add options like suggested in #5733 then?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the Dataset and DataArray identical entry points and inspect how comparisons currently handle variables, coordinates, attributes, and explicit indexes. Verify the intended behavior for differing xindexes, including whether index and attribute checks need separate options; done means tests distinguish objects with different indexes.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100