pydata / pydata/xarray

small contrast of html view in VScode darkmode

Open
#4,024 24 comments 1 reaction 0 assignees View on GitHub

Nobody has claimed this yet.

contrib-help-wanted topic-html-repr
Dominant language
Python
Stars
4.2k
Forks
1.4k
Avg merge
2d 15h
Merged PRs (30d)
14

Description

If using xarray inside VScode with darkmode, the new html repr has a small contrast of the text color and background.

image

Maybe the text color comes from the default setting, but the background color is not.
In light mode, it looks nice.

Versions
Output of xr.show_versions() INSTALLED VERSIONS ------------------ commit: None python: 3.7.5 (default, Oct 25 2019, 15:51:11) [GCC 7.3.0] python-bits: 64 OS: Linux OS-release: 4.15.0-1080-oem machine: x86_64 processor: x86_64 byteorder: little LC_ALL: None LANG: en_US.UTF-8 LOCALE: en_US.UTF-8 libhdf5: 1.10.4 libnetcdf: 4.6.1

xarray: 0.15.1
pandas: 0.25.3
numpy: 1.17.4
scipy: 1.3.2
netCDF4: 1.4.2
pydap: None
h5netcdf: 0.8.0
h5py: 2.9.0
Nio: None
zarr: None
cftime: 1.0.4.2
nc_time_axis: None
PseudoNetCDF: None
rasterio: None
cfgrib: None
iris: None
bottleneck: 1.3.1
dask: 2.9.0
distributed: 2.9.0
matplotlib: 3.1.1
cartopy: None
seaborn: 0.9.0
numbagg: None
setuptools: 42.0.2.post20191203
pip: 19.3.1
conda: None
pytest: 5.3.2
IPython: 7.10.2
sphinx: 2.3.0

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing xarray's new HTML repr in VSCode dark mode and compare it with light mode. Inspect the generated HTML and its text and background colors; the issue is done when the repr has readable contrast in both modes.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, vscode
Domain
frontend, web-dev
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.