Don't write unnecessary _FillValue=NaN for Zarr files
Open
Nobody has claimed this yet.
topic-zarr
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
What is your issue?
As pointed out by @rabernat in https://github.com/pydata/xarray/pull/10757, there is no point in writing _FillValue attributes set to NaN in Zarr files.
This makes Zarr stores created with Xarray a bit more complex than necessary, and may unnecessarily invoke Xarray's masking / fill value machinery.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing Xarray's Zarr serialization and the masking/fill-value machinery discussed in the issue and linked pull request #10757. Confirm the behavior by creating a Zarr store and inspecting its attributes; done means unnecessary _FillValue attributes set to NaN are no longer written.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Refactor
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100