Support `drop_incomplete` kwarg with `SeasonGrouper`
Open
Nobody has claimed this yet.
contrib-help-wanted
enhancement
topic-groupby
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
Is your feature request related to a problem?
This should drop any seasons that don't have complete coverage in the data as we do for SeasonResampler.
I have not thought about this in a long time, but perhaps the code in SeasonResampler can be generalized
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by comparing the SeasonGrouper and SeasonResampler implementations and their existing behavior for incomplete seasons. Add support for the drop_incomplete keyword argument so seasons without complete data coverage are omitted consistently, and verify the resulting grouping behavior with the relevant tests.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- data
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100