roundtripping bytes with specific _FillValue fails on Zarr 3.0.7
Open
Nobody has claimed this yet.
bug
topic-zarr
- Dominant language
- Python
- Stars
- 4.2k
- Forks
- 1.4k
- Avg merge
- 2d 15h
- Merged PRs (30d)
- 14
Description
What happened?
Seen in CI. I have xfailed the Zarr test in #10255
xarray/tests/test_backends.py::TestZarrDictStore::test_roundtrip_bytes_with_fill_value[2]: AssertionError: Left and right Dataset objects are not identical
Differing data variables:
L x (t) object 24B b'ab' b'cdef' nan
R x (t) object 24B b'ab' b'cdef' b'X'
xarray/tests/test_backends.py::TestZarrDirectoryStore::test_roundtrip_bytes_with_fill_value[2]: AssertionError: Left and right Dataset objects are not identical
Differing data variables:
L x (t) object 24B b'ab' b'cdef' nan
R x (t) object 24B b'ab' b'cdef' b'X'
xarray/tests/test_backends.py::TestZarrWriteEmpty::test_roundtrip_bytes_with_fill_value[2]: AssertionError: Left and right Dataset objects are not identical
Differing data variables:
L x (t) object 24B b'ab' b'cdef' nan
R x (t) object 24B b'ab' b'cdef' b'X'
This is probably an upstream issue, https://github.com/zarr-developers/zarr-python/issues/2979 but we should remember to remove the xfail when upstream is fixed.
cc @ianhi
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the three named tests in xarray/tests/test_backends.py and check upstream zarr-developers/zarr-python issue 2979 for the fix status. When the upstream issue is fixed, remove the xfail from the affected Zarr cases and run the listed roundtrip tests to confirm bytes with a specific _FillValue are preserved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100