pydata / pydata/xarray

Tracking internal uses of concat that don't allow setting all the kwargs

Open
#10,095 0 comments 3 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

topic-combine topic-groupby topic-internals
Dominant language
Python
Stars
4.2k
Forks
1.4k
Avg merge
2d 15h
Merged PRs (30d)
14

Description

What is your issue?

While working on #8778 I encountered some places where concat is used internally but the kwargs are not individually settable: stack and groupby.

#10062 hardcodes them to the old defaults: data_vars="all", coords="different", compat="equals", join="outer"

@dcherian mentioned (https://github.com/pydata/xarray/pull/10062/files#r1978040669) that we might want stricter behavior.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by inspecting the internal concat uses in stack and groupby, then compare their hardcoded defaults with #10062 and the discussion linked from #8778. The issue needs a decided scope for individually settable kwargs and stricter behavior; completion should cover the identified uses consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.