pydantic / pydantic/pytest-examples
Assertions inside exceptions are silently not checked
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 178
- Forks
- 25
- Avg merge
- 4d 1h
- Merged PRs (30d)
- 7
Description
e.g.:
from pydantic import BaseModel, ValidationError
class Model(BaseModel):
num: complex
try:
Model(num=complex(1)) # works
except ValidationError as exc:
print(repr(exc.errors()[0]['type']))
#> 'complex_type'
This will pass tests, because the exception was never raised. This happened several times in pydantic, where such code was indeed raising when writing, but behavior changed over time.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reproducing the provided Pydantic ValidationError example in the pytest-examples plugin's handling of examples in docstrings and Markdown files. Trace how exception blocks and their assertions are evaluated; done means a test cannot pass when the expected exception is never raised, while existing valid examples continue to work.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- testing-qa
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 65/100