pydantic / pydantic/logfire-rust

Support tags

Open
#18 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
77
Forks
10
Avg merge
8h 26m
Merged PRs (30d)
5

Description

The logfire Python SDK supports adding tags to spans and logs. We should update our macros to have an optional tags: [tags] argument (probably before the positional ones).

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Rust macro definitions and reviewing how they currently accept positional arguments. Compare the supported tag behavior in the Python SDK, then determine how the optional tags argument should be handled for spans and logs. Done means the macros accept tags without breaking existing calls and the relevant behavior is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.