pydantic / pydantic/httpx2

Requests for new public APIs

Open
#821 11 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.5k
Forks
78
Avg merge
8h 59m
Merged PRs (30d)
24

Description

Originally opened by @karpetrosyan on 2024-04-21 09:09:59 in encode/httpx

Ref: https://github.com/encode/starlette/pull/2534#issuecomment-2067634124

This issue was opened to resolve all kinds of problems where third-party packages may need to use private imports. We should definitely expose them to avoid problems like https://github.com/encode/httpx/pull/3130#issuecomment-1974778017.

I will include the package name along with its private imports (only starlette for now), so we can clearly identify what needs to be exposed.

Note that:

  • -> Not yet publicly exposed
  • -> Publicly exposed

We can also add other packages as well to track all of them in this issue.

Starlette

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Starlette starlette/testclient.py references and inspect how each listed private httpx symbol is used. Check the corresponding public-API definitions and existing tests before deciding the exposure needed. Done means the checklist items are publicly available without private imports and the relevant tests pass.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api, backend-api-design
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.