_send_single_request logs sensitive data / leaks credentials
Open
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 76
- Avg merge
- 8h 59m
- Merged PRs (30d)
- 24
Description
Originally opened by
@Netherwhalon 2023-07-08 15:26:02 in encode/httpx
Logs should not leak sensitive credentials/data - especially not in with log-level info.
Unfortunately httpx will log the full URL of the HTTP request, including username and password.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Locate the _send_single_request entry point and reproduce an HTTP request whose URL contains username and password while info logging is enabled. Trace the logging path and add a regression test for the reported case; done means sensitive credentials and data are not exposed in logs.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100