pyca / pyca/pyopenssl

TestOCSP.test_client_receives_servers_data fails with openssl 3.6.0

Open
#1,455 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
944
Forks
440
Avg merge
1d 6h
Merged PRs (30d)
6

Description

Hi, thank you for maintaining this useful tool! I am observing a test failure with openssl 3.6.0, the test was passing with openssl 3.5.4. Here is the error in TestOCSP.test_client_receives_servers_data:

[   18s] >       assert calls[0] == self.sample_ocsp_data
[   18s] E       AssertionError: assert b'' == b'this is totally ocsp data'
[   18s] E         
[   18s] E         Full diff:
[   18s] E         - (b'this is totally ocsp data')
[   18s] E         + b''

I would guess it has something to do with https://github.com/openssl/openssl/commit/b1b4b154fd389ac6254d49cfb11aee36c1c51b84, maybe some defaults changed? But I am unable to get to the bottom of this, could you please take a look?

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with TestOCSP.test_client_receives_servers_data and reproduce the failure with OpenSSL 3.6.0, comparing it with 3.5.4. Read the referenced OpenSSL commit and trace why calls[0] is empty instead of self.sample_ocsp_data; done means the test passes with the supported OpenSSL versions.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.