pyca / pyca/pyopenssl

SSL_CTX_set_cipher_list missing implementation

Open
#1,224 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
944
Forks
440
Avg merge
1d 6h
Merged PRs (30d)
6

Description

In regards to set_ciphers method in Context class and taking into account of openssl docs - setting ciphers for TLSv1.3 (in order to achieve any effect) must be set via SSL_set_ciphersuites - elsewhere set_ciphers wont take any effect or raise exception - so that, changes require to distinguish between protocol versions - propably here: https://github.com/pyca/pyopenssl/blob/main/src/OpenSSL/SSL.py#L1327

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in src/OpenSSL/SSL.py around the Context.set_ciphers method at line 1327, then consult the OpenSSL documentation for SSL_CTX_set_cipher_list and SSL_set_ciphersuites. Trace how protocol versions are handled and verify that TLS 1.3 cipher configuration uses the appropriate API while other versions retain the existing behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
security
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.