PR #709 breaks python 3.6.1 compatibility
Open
Beginner friendly
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.2k
- Forks
- 267
- Avg merge
- 42m
- Merged PRs (30d)
- 2
Description
https://github.com/pyca/pynacl/pull/709
src/nacl/bindings/crypto_generichash.py:14
from typing import NoReturn, TypeVar
NoReturn was introduced in python 3.6.2, on 3.6.1 fails with:
ImportError: cannot import name ‘NoReturn’
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with src/nacl/bindings/crypto_generichash.py and reproduce the import failure under Python 3.6.1. Check the project's compatibility tests or supported-version configuration, then verify that the binding imports successfully on Python 3.6.1 while retaining support for newer versions.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- security
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- Under an hour
- Activity status
- Stale
- Clarity
- Clearly specified
- Newbie friendliness
- 62/100