Have classes `nacl.encoding` implement an ABC
Open
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.2k
- Forks
- 267
- Avg merge
- 42m
- Merged PRs (30d)
- 2
Description
It might be a good idea to define an ABC that all the classes in the nacl.encoding module implement. It will then be possible to do a isinstance check on all the places that takes a encoder as a parameter to make sure no one passes in anything stupid.
Thoughts?
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing the classes in the nacl.encoding module and the places that accept an encoder. Determine the ABC contract and which classes and encoder parameters should use it. Done means all relevant encoding classes implement the ABC and encoder inputs can be checked consistently.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cryptography
- Issue type
- Feature
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100