Creation of box from zero public key raises RuntimeError: Unexpected library error
Nobody has claimed this yet.
- Dominant language
- C
- Stars
- 1.2k
- Forks
- 267
- Avg merge
- 42m
- Merged PRs (30d)
- 2
Description
A simple way to reproduce this bug is
import nacl.public
sk_bob = nacl.public.PrivateKey.generate()
pk_alice = nacl.public.PublicKey(bytes(32))
box = nacl.public.Box(sk_bob, pk_alice)
IIRC in X25519 zero public key leads to zero shared secret, so it's understandable libsodium raises exception in this case. I think pynacl should handle the detection and raise ValueError with understandable description along the lines of Zero public keys are not allowed.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the nacl.public.Box construction shown in the reproduction and run it to observe the current RuntimeError. Trace how the zero PublicKey reaches Box, then make the failure a ValueError with an understandable message and rerun the reproduction to confirm the completed behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- cryptography, security
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100