pybind / pybind/pybind11_protobuf

Request: change std::optional to absl::optional

Open
#184 3 comments 2 reactions 1 assignee View on GitHub

@Mizux is already working on this.

Since Dec 13, 2024.

bug
Dominant language
C++
Stars
67
Forks
37
No merged PRs in 30d

Description

This repo uses a lot of other absl headers, but it uses the std::optional header. This is the sole thing that necessitates C++17. If these types are changed to be absl::optional, C++17 is no longer required, and C++14 is sufficient.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.