[BUG]: std::move_constructible and pybind11::detail::is_move_constructible differ
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18k
- Forks
- 2.3k
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 10
Description
Required prerequisites
- Make sure you've read the documentation. Your issue may be addressed there.
- Search the issue tracker and Discussions to verify that this hasn't already been reported. +1 or comment there if it has.
- Consider asking first in the Gitter chat room or in a Discussion.
What version (or hash if on master) of pybind11 are you using?
3.0.1
Problem description
I'm not sure this is a bug.
Must std::move_constructible concept and pybind11::is_move_constructible evaluate the same?
When a struct has a value_type member typedef set to void the two predicates differ (cf. code below).
I stumbled into this problem using CGAL (cf. https://github.com/CGAL/cgal/issues/9319).
Reproducible example code
#include <concepts>
#include <pybind11/pybind11.h>
struct A {
typedef int value_type;
};
static_assert(std::move_constructible<A>); // OK
static_assert(pybind11::detail::is_move_constructible<A>::value); // OK
struct B {
typedef void value_type;
};
static_assert(std::move_constructible<B>); // OK
static_assert(pybind11::detail::is_move_constructible<B>::value); // fails
Is this a regression? Put the last known working version here if it is.
Not a regression
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproducible static assertions and trace the definition of pybind11::detail::is_move_constructible included through pybind11/pybind11.h. Compare its behavior with std::move_constructible for the A and B examples, then inspect existing trait tests if present. Done means the differing behavior is either aligned with the standard concept or clearly justified and covered by a regression test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp
- Domain
- devtools
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 42/100