pybind / pybind/pybind11

[BUG]: If indicies of scipy.csc_matrix are not sorted conversion to Eigen::SparseMatrix Fails in debug mode.

Open
#5,819 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
C++
Stars
18k
Forks
2.3k
Avg merge
5d 17h
Merged PRs (30d)
10

Description

Required prerequisites
What version (or hash if on master) of pybind11 are you using?

2.13.6

Problem description

scipy sparse matrix could have unsorted indicies. Conversion to Eigen type leads assertion:
eigen_assert( (m_outerIndex[outer+1]-m_outerIndex[outer]==0 || m_data.index(m_data.size()-1)<inner) && "Invalid ordered insertion (invalid inner index)");
However, if you call sort_indicies() before cast conversion would be correct.

Reproducible example code

Is this a regression? Put the last known working version here if it is.

Not a regression

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing pybind11's scipy.csc_matrix to Eigen::SparseMatrix conversion and compare behavior with the reported sort_indices() workaround. Reproduce the debug assertion using an unsorted sparse matrix; done means conversion succeeds and preserves the correct sparse values and indices.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
backend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.