pybind / pybind/pybind11

[WARING]: Compile Warning

Open
#5,610 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
C++
Stars
18k
Forks
2.3k
Avg merge
5d 17h
Merged PRs (30d)
10

Description

Required prerequisites
What version (or hash if on master) of pybind11 are you using?

master

Problem description

We notice the compile warning in this file [include/pybind11/complex.h:58]

The warning is shown below:
warning: comparing floating point with == or != is unsafe [-Wfloat-equal]

Detail Code is shown below:
if (result.real == -1.0 && PyErr_Occurred())

I would like to konw your team will consider resolving this compilation alert ? In which version will the compilation alarm be removed ?

Reproducible example code

Is this a regression? Put the last known working version here if it is.

Not a regression

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Inspect include/pybind11/complex.h at line 58 and reproduce the reported -Wfloat-equal warning around the comparison involving result.real and PyErr_Occurred(). Determine the intended behavior for this check, then verify that the warning is gone without changing error handling.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
api
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.