[WARING]: Compile Warning
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18k
- Forks
- 2.3k
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 10
Description
Required prerequisites
- Make sure you've read the documentation. Your issue may be addressed there.
- Search the issue tracker and Discussions to verify that this hasn't already been reported. +1 or comment there if it has.
- Consider asking first in the Gitter chat room or in a Discussion.
What version (or hash if on master) of pybind11 are you using?
master
Problem description
We notice the compile warning in this file [include/pybind11/complex.h:58]
The warning is shown below:
warning: comparing floating point with == or != is unsafe [-Wfloat-equal]
Detail Code is shown below:
if (result.real == -1.0 && PyErr_Occurred())
I would like to konw your team will consider resolving this compilation alert ? In which version will the compilation alarm be removed ?
Reproducible example code
Is this a regression? Put the last known working version here if it is.
Not a regression
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Inspect include/pybind11/complex.h at line 58 and reproduce the reported -Wfloat-equal warning around the comparison involving result.real and PyErr_Occurred(). Determine the intended behavior for this check, then verify that the warning is gone without changing error handling.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- api
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100