[BUG]: acquire gil in new thread fails (access violation)
Open
Nobody has claimed this yet.
triage
- Dominant language
- C++
- Stars
- 18k
- Forks
- 2.3k
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 10
Description
Required prerequisites
- Make sure you've read the documentation. Your issue may be addressed there.
- Search the issue tracker and Discussions to verify that this hasn't already been reported. +1 or comment there if it has.
- Consider asking first in the Gitter chat room or in a Discussion.
What version (or hash if on master) of pybind11 are you using?
2.12.0
Problem description
py::gil_scoped_acquire shall be ok to be used in cpp threads, but the example code would crush (access violation) when calling foo.test().
Reproducible example code
#include "pybind11/gil.h"
#include "pybind11/pybind11.h"
#include <stdio.h>
#include <thread>
namespace py = pybind11;
void test() {
printf("acquire gil\n");
py::gil_scoped_acquire acquire; // ok here
std::thread([](){
printf("acquire gil in new thread\n");
py::gil_scoped_acquire acquire; // crush here
}).join();
printf("exit test\n");
}
PYBIND11_MODULE(foo, m) {
m.def("test", &test);
}
Is this a regression? Put the last known working version here if it is.
Not a regression
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the reproducer in the issue and read pybind11/gil.h, focusing on py::gil_scoped_acquire when used in the std::thread launched by test(). Run the foo.test() example under the affected setup and trace the access violation. Done means the nested C++ thread can acquire the GIL without crashing while preserving the existing outer acquisition behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- backend-api-design
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100