pybind / pybind/pybind11

[BUG]: -flto=thin from CMAKE_INTERPROCEDURAL_OPTIMIZATION_CONFIG is not respected

Open
#5,088 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
C++
Stars
18k
Forks
2.3k
Avg merge
5d 17h
Merged PRs (30d)
10

Description

Required prerequisites
What version (or hash if on master) of pybind11 are you using?

f33f6afb667b6b5c0da7dee98dc02f51b4cc0e96

Problem description

I want to enable lto in Release mode only. I added set(CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELEASE TRUE) in my CMakeLists.txt.

Since I didn't set CMAKE_INTERPROCEDURAL_OPTIMIZATION, line https://github.com/pybind/pybind11/blob/f33f6afb667b6b5c0da7dee98dc02f51b4cc0e96/tools/pybind11Common.cmake#L397 think I didn't already enabled -flto=thin and add -flto. So when building in Release mode, I have : -flto=thin -flto.

I bypass the problem by setting THIN_LTO in pybind11_add_module.

Reproducible example code

No response

Is this a regression? Put the last known working version here if it is.

Not a regression

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Read tools/pybind11Common.cmake around line 397, then configure a Release build with CMAKE_INTERPROCEDURAL_OPTIMIZATION_RELEASE enabled and inspect the generated flags. Done means the configuration respects the requested ThinLTO setting without adding a duplicate or conflicting -flto option.

Written by the indexing model from the issue text.

Assessment

Tech stack
cmake, cpp
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.