pybind / pybind/pybind11

[BUG]: Coverity issue in dispatcher: Possible dereferencing null pointer self_value_and_holder.type

Open
#4,821 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

triage
Dominant language
C++
Stars
18k
Forks
2.3k
Avg merge
5d 17h
Merged PRs (30d)
10

Description

Required prerequisites
What version (or hash if on master) of pybind11 are you using?

2.10.2

Problem description

Coverity scan highlights possible explicit null pointer dereferencing in pybind11 dispatcher function in "pybind11.h".

The tools indicates that self_value_and_holder variable is initialized with default-constructed value_and_holder class which sets type pointer to NULL:

image

It stays NULL if overloads->is_constructor condition is false.

The type field is dereferenced here:

image

This maybe a false positive, since func.is_new_style_constructor might imply overloads->is_constructor, `but I could not determine that conclusively, hence this issue.

Reproducible example code

No response

Is this a regression? Put the last known working version here if it is.

Not a regression

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in pybind11.h at the dispatcher function and trace value_and_holder initialization alongside the overloads->is_constructor and func.is_new_style_constructor conditions. Review the Coverity warning and relevant control flow to determine whether the dereference is safe; done means the warning is resolved or its false-positive status is conclusively established.

Written by the indexing model from the issue text.

Assessment

Tech stack
cpp, python
Domain
tooling
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.