[BUG]: Coverity issue in dispatcher: Possible dereferencing null pointer self_value_and_holder.type
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18k
- Forks
- 2.3k
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 10
Description
Required prerequisites
- Make sure you've read the documentation. Your issue may be addressed there.
- Search the issue tracker and Discussions to verify that this hasn't already been reported. +1 or comment there if it has.
- Consider asking first in the Gitter chat room or in a Discussion.
What version (or hash if on master) of pybind11 are you using?
2.10.2
Problem description
Coverity scan highlights possible explicit null pointer dereferencing in pybind11 dispatcher function in "pybind11.h".
The tools indicates that self_value_and_holder variable is initialized with default-constructed value_and_holder class which sets type pointer to NULL:
It stays NULL if overloads->is_constructor condition is false.
The type field is dereferenced here:
This maybe a false positive, since func.is_new_style_constructor might imply overloads->is_constructor, `but I could not determine that conclusively, hence this issue.
Reproducible example code
No response
Is this a regression? Put the last known working version here if it is.
Not a regression
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in pybind11.h at the dispatcher function and trace value_and_holder initialization alongside the overloads->is_constructor and func.is_new_style_constructor conditions. Review the Coverity warning and relevant control flow to determine whether the dereference is safe; done means the warning is resolved or its false-positive status is conclusively established.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- tooling
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100