[BUG] Possible issue in C++17 mode?
Nobody has claimed this yet.
- Dominant language
- C++
- Stars
- 18k
- Forks
- 2.3k
- Avg merge
- 5d 17h
- Merged PRs (30d)
- 10
Description
Issue description
I have a class A and a subclass B, both registered by pybind11.
When enabling C++17 mode, I had to replace B::size with a lambda function, as pybind11 suddenly started tying this to "A", which was previously correctly using the correct thing in C++14 mode. Seems to happen on both GCC and Clang.
Reproducible example code
Might try to build a minimal example later , just wanted to get this in so I don't forget. Change to make tests pass here: https://github.com/scikit-hep/boost-histogram/pull/502/commits/6c93370e96b486f948ac7cef055dedcc6165e7d0 "boolean" is my subclass, and "integer_none" is the previously registered parent. https://github.com/scikit-hep/boost-histogram/pull/502
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with the referenced boost-histogram pull request and commit, comparing the C++14 and C++17 behavior for the registered parent and subclass. Produce a minimal reproducible example for the pybind11 binding issue; done means the correct subclass member is selected in both compiler modes and the regression is covered by a test.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- cpp, python
- Domain
- backend-api-design
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100