pybind / pybind/pybind11

numpy, eigen: Consider syncing up with NumPy typing?

Open
#2,378 5 comments 0 reactions 1 assignee View on GitHub

@EricCousineau-TRI is already working on this.

Since Aug 10, 2020.

on hold
Dominant language
C++
Stars
18k
Forks
2.3k
Avg merge
5d 17h
Merged PRs (30d)
10

Description

NumPy currently has some different sub-issues regarding this campaign:
https://github.com/numpy/numpy/issues/7370#issuecomment-671540503

Depending on that resolution, is it worthwhile to converge on using those type annotations (if/when they accommodate multiple dimensions, being writeable, storage order, etc.)?

Thoughts?
@rwgk @wjakob @bstaletic @YannickJadoul

FWIW I like these annotations the most so far:
https://github.com/ramonhagenaars/nptyping/issues/27

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.