Potential data mismatch in scattering_factors.txt for elements Rb and Sr (lines 37-38)
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 279
- Forks
- 177
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
I would like to report a possible bug in the scattering_factors.txt file located in the /process/utils/ directory.
It appears that the scattering factor data for Rubidium (Rb) (line 37) and Strontium (Sr) (line 38) might be swapped. This inconsistency was noticed when comparing with the reference data from:
Ivan Lobato and Dirk Van Dyck. Acta Crystallographica Section A, 70:636–649, 2014.
Additionally, the same discrepancy is observed when comparing with the scattering factor parameters used in abtem (which also cites the same reference).
This could lead to incorrect simulations—such as Bloch wave or multislice simulations—for structures containing these elements, for example, the common standard sample SrTiO₃ (STO).
Could you please verify and correct this if confirmed?
Thank you for your attention and efforts!
Steps to reproduce (if applicable):
- Open scattering_factors.txt in /process/utils/.
- Compare lines 37 (Rb) and 38 (Sr) with Table 1 or Table 5 of Lobato & Van Dyck (2014).
- Alternatively, compare with the scattering factor data used in abtem for Rb and Sr.
Expected behavior:
The scattering factor parameters for Rb and Sr should match the reference values from Lobato & Van Dyck (2014).
Actual behavior:
The values appear to be swapped between Rb and Sr in the file.
Environment (if relevant):
py4DSTEM version: [0.14.18]
Operating system: [Windows]
Additional context:
This issue may affect simulations of materials containing Rb or Sr, especially in quantitative electron diffraction or imaging simulations.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Open /process/utils/scattering_factors.txt and inspect lines 37-38 for Rb and Sr. Compare both entries with Table 1 or Table 5 of Lobato and Van Dyck (2014), or the corresponding abTEM parameters. Done means confirming whether the values are swapped and correcting the file if the reference comparison confirms the mismatch.
Written by the indexing model from the issue text.
Assessment
- Domain
- data
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 62/100