py4dstem / py4dstem/py4DSTEM

Calibration of Q_pixel_size for rectangular pixels

Open
#715 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
279
Forks
177
PR merge metrics
No merged PRs in 30d

Description

Hi everyone, thank you for this nice package!

Is your feature request related to a problem? Please describe.
I have been running into issues calibrating data that has rectangular pixels (e.g. datasets simulated with abTEM). Sometimes the sampling is different in x and y direction for reasons related to the simulations, so it would be great to have the possibility to give two values for the Q_pixel_size calibration.

Describe the solution you'd like
The possibility to calibrate the dataset with different values for the x and y Q_pixel_size.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

The issue names no files or tests. Start by locating the Q_pixel_size calibration entry point and related tests, then trace how one sampling value is passed through dataset calibration. Done means x and y values can be supplied independently and rectangular-pixel calibration is covered by tests.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
data
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.