Histogram does not obey min/max limits
Open
@bsavitzky is already working on this.
Since Oct 19, 2021.
enhancement
- Dominant language
- Python
- Stars
- 279
- Forks
- 177
- PR merge metrics
- No merged PRs in 30d
Description
When using py4DSTEM.isualize.show(arr, hist=True) to generate a histogram, there is no way to specify the limits of the histogram, i.e. the min and max args are never used when hist=True. Instead we always use the min and max of the masked/scaled array:
https://github.com/py4dstem/py4DSTEM/blob/7e4933ecd593e36702a4b7a34ee13c67d2ffea9d/py4DSTEM/visualize/show.py#L325-L332
It would be useful to let the user specify the desired range.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.