py-why / py-why/causal-learn

FAS does not use required edges anymore

Open
#94 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.7k
Forks
274
PR merge metrics
No merged PRs in 30d

Description

Hi,

Since the new commit on Fas.py, the required edges are not used anymore to create the graph. May I ask why and what the benefit of this is? I made a program for which the required edges were essential, so I am very curious 😅

Kind regards,
Vera

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing the recent changes in Fas.py and trace how required edges are handled when the graph is created. Compare the current behavior with the issue's described expectation and determine whether the change is intentional. Done means the required-edge behavior and its rationale are clarified, with a fix only if the current behavior is confirmed to be incorrect.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.