py-why / py-why/causal-learn

PNL - Test2

Open
#153 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.7k
Forks
274
PR merge metrics
No merged PRs in 30d

Description

Hello.
I was applying the PNL algorithm to some data and was getting unexpected results.
Upon running the tests, I get an error in test_pnl_simulation_2, for the p_value_forward_2 value.
Is there a known problem regarding this?
Screenshot from 2023-11-22 15-41-45
Thank you

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reproducing the failure in test_pnl_simulation_2 and inspect the assertion involving p_value_forward_2. Use the screenshot and test output to determine whether the unexpected value comes from the PNL implementation, test data, or expected result; done means the cause is documented and the test has a justified outcome.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.