py-why / py-why/causal-learn

Consistency parameter in independence_test_method

Open
#151 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.7k
Forks
274
PR merge metrics
No merged PRs in 30d

Description

I noticed that for example the CDNOD calls them:
indep_test: Independence test method function. Default: ‘fisherz’.
But FCI:
independence_test_method: Independence test method function. Default: ‘fisherz’.

I think we should unify all the methods to use the same keyword?
Cheers.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Search the Python implementation for the CDNOD and FCI entry points, then compare uses of indep_test and independence_test_method across the other methods. Decide on the consistent keyword from the existing API and documentation, update all affected references, and verify that the method signatures and examples use the same name.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
api
Issue type
Refactor
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
38/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.