py-why / py-why/causal-learn

PC algorithm logic

Open
#129 3 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.7k
Forks
274
PR merge metrics
No merged PRs in 30d

Description

In the causal-learn/causallearn/utils/PCUtils/SkeletonDiscovery.py, why does it need to add sepsets to cp.sepset at lines 123-124? If the p-value return at line 101 is not greater than alpha for all S in line 100, doesn't that mean you force an empty set to be a separating set?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in causal-learn/causallearn/utils/PCUtils/SkeletonDiscovery.py and trace the loop over S at line 100, the p-value check at line 101, and the sepsets assignment at lines 123-124. Determine whether the empty separating set is intentional under that control flow; done when the behavior is explained or the identified logic issue is clearly resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
machine-learning
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
28/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.