shape of effects when X=None
Open
@heimengqi is already working on this.
Since Sep 29, 2019.
enhancement
- Dominant language
- Jupyter Notebook
- Stars
- 4.8k
- Forks
- 827
- PR merge metrics
- No merged PRs in 30d
Description
When X is None, then const_marginal_effect() and effect() and marginal_effect() return a result that is of shape (1, d_y, d_t). The leading 1 seems weird to me. In this extreme case where the user wants average treatment effects, then we should not me adding the leading 1 in these results.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.