py-why / py-why/EconML

Unable to run tests

Open
#913 2 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Jupyter Notebook
Stars
4.8k
Forks
827
PR merge metrics
No merged PRs in 30d

Description

Hi, I'm working on a PR but first I'd like to make sure I can get all tests running. I followed all of the instructions in the For Developers, Pre-commit hooks, and Running the tests section of the README. When I run the command python setup.py pytest I get the following:

(econml) C:\Users\ronik\Desktop\EconML>python setup.py pytest
C:\Users\ronik\anaconda3\envs\econml\lib\site-packages\ptr\__init__.py:81: SetuptoolsDeprecationWarning: The test command is disabled and references to it are deprecated.
!!

        ********************************************************************************
        Please remove any references to `setuptools.command.test` in all supported versions of the affected package.

        By 2024-Nov-15, you need to update your project and remove deprecated calls
        or your builds will no longer be supported.
        ********************************************************************************

!!
  class PyTest(orig.test):
running pytest
Traceback (most recent call last):
  File "setup.py", line 34, in <module>
    setup(ext_modules=c_extensions + pyx_extensions,
  File "C:\Users\ronik\anaconda3\envs\econml\lib\site-packages\setuptools\__init__.py", line 111, in setup
    return distutils.core.setup(**attrs)
  File "C:\Users\ronik\anaconda3\envs\econml\lib\site-packages\setuptools\_distutils\core.py", line 184, in setup
    return run_commands(dist)
  File "C:\Users\ronik\anaconda3\envs\econml\lib\site-packages\setuptools\_distutils\core.py", line 200, in run_commands
    dist.run_commands()
  File "C:\Users\ronik\anaconda3\envs\econml\lib\site-packages\setuptools\_distutils\dist.py", line 964, in run_commands
    self.run_command(cmd)
  File "C:\Users\ronik\anaconda3\envs\econml\lib\site-packages\setuptools\dist.py", line 948, in run_command
    super().run_command(command)
  File "C:\Users\ronik\anaconda3\envs\econml\lib\site-packages\setuptools\_distutils\dist.py", line 983, in run_command
    cmd_obj.run()
  File "C:\Users\ronik\anaconda3\envs\econml\lib\site-packages\ptr\__init__.py", line 195, in run
    setattr(dist, attr, getattr(self.distribution, attr))
AttributeError: 'Distribution' object has no attribute 'tests_require'

This is with python 3.8.x. Any suggestions?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the README's “For Developers, Pre-commit hooks, and Running the tests” section and inspect setup.py alongside the reported python setup.py pytest traceback. Check how the ptr test command handles tests_require under Python 3.8. Done means the documented command runs without the Distribution AttributeError and executes the test suite.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
build-system, testing-qa
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.