py-why / py-why/EconML

Consistent notation for learner APIs

Open
#554 1 comment 0 reactions 1 assignee View on GitHub

@kbattocchi is already working on this.

Since Jan 3, 2022.

Dominant language
Jupyter Notebook
Stars
4.8k
Forks
827
PR merge metrics
No merged PRs in 30d

Description

Would it be possible to harmonize the notation across the different learners? For example, the treatment propensity model is referred to as model_t in CausalForest, model_T in DMLOrthoForest, propensity_model in XLearner, and as model_propensity in ForestDRLearner.
Same for model_y, etc

That introduces confusion and complicates code reuse, for no good reason that I can see.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.