Question about EconML's S-Learner implementation
Nobody has claimed this yet.
- Dominant language
- Jupyter Notebook
- Stars
- 4.8k
- Forks
- 827
- PR merge metrics
- No merged PRs in 30d
Description
Hi, I'm looking at the SLearner Meta Learner implementation, and in the code there's a note describing that the treatment for control column is added to the feature set too. Could anyone explain why we need to do this? For example, thinking of a binary treatment value, after the OHE we just need one column (as the note itself explains, since it can be linearly derived from the other).
Was it for any abstraction/implementation reason? Asking this because in some tests of reimplementing a Slearner the model was outputting a different result than EconML implementation, but we weren't adding this control column like EconML does.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reading econml/metalearners/_metalearners.py around line 170 and compare the S-Learner behavior with the reimplementation tests described in the issue. Done would require a confirmed explanation of the control column's purpose and, if appropriate, documenting that rationale or identifying the relevant implementation behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- machine-learning
- Issue type
- Documentation
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100