py-why / py-why/EconML

Checking consistent length in `cate_feature_names`, `cate_output_names`, `cate_treatment_names`

Open
#436 0 comments 0 reactions 1 assignee View on GitHub

@moprescu is already working on this.

Since Mar 21, 2021.

bug
Dominant language
Jupyter Notebook
Stars
4.8k
Forks
827
No merged PRs in 30d

Description

In all three methods: cate_feature_names, cate_output_names, cate_treatment_names
we should be checking that the passed list of names is consistent with the internal fitted length and raise an error otherwise:

https://github.com/microsoft/EconML/blob/7005b242531669854f9e0b6b944b590b9b4fdf66/econml/_cate_estimator.py#L254
https://github.com/microsoft/EconML/blob/7005b242531669854f9e0b6b944b590b9b4fdf66/econml/_cate_estimator.py#L277
https://github.com/microsoft/EconML/blob/7005b242531669854f9e0b6b944b590b9b4fdf66/econml/_cate_estimator.py#L231

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.