py-why / py-why/EconML

shap_values call with dimension mismatch

Open
#428 0 comments 0 reactions 1 assignee View on GitHub

@heimengqi is already working on this.

Since Mar 9, 2021.

bug
Dominant language
Jupyter Notebook
Stars
4.8k
Forks
827
PR merge metrics
No merged PRs in 30d

Description

When the shap values is called with a mis-matched X not matching the training dimension, then we revert to the slow exact calculation of shap values, because of the raised error. Instead we should be checking the input dim is matching and if not raising an error.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.