Ortholearner fitfinal does not get the expanded treatment
Open
@heimengqi is already working on this.
Since Nov 12, 2020.
enhancement
- Dominant language
- Jupyter Notebook
- Stars
- 4.8k
- Forks
- 827
- PR merge metrics
- No merged PRs in 30d
Description
Currently the expanded treatment is passed only to the nuisance models but not the final model.
This has not affected any behavior so far as all our estimators dont use the raw treatment in the final stage ever. But for uniformity and potential future estimators we should adhere I believe to always passing the expanded treatment when discrete_treatment=True.
Most prob the treatment expansion snippet needs to move to the fit method not inside the fit_nuisance method.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.