Improving on access to first stage nuisance models
@heimengqi is already working on this.
Since Nov 23, 2019.
- Dominant language
- Jupyter Notebook
- Stars
- 4.8k
- Forks
- 827
- PR merge metrics
- No merged PRs in 30d
Description
Currently in DMLCateEstimators we return the scikit-learn models_y and models_t and not the first stage wrappers around them. This makes it hard for someone to access these models and predict on a set of functions to see how well they performed, because they would need to combine the X and W themselves. We mostly did this so that the user can access easily the properties of the first stage models as if it was a scikit-learn estimator. But this makes prediction hard.
One solution would be to return the first stage wrappers, but we need to make the first stage wrappers inherit the properties of the wrapped models, so that the user can do:
model.predict(X, W)
but then also be able to do things like
model.coef_
model.feature_importances_
etc.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.