py-why / py-why/EconML

Bootstrap estimator for ORF

Open
#184 2 comments 0 reactions 2 assignees View on GitHub

@vasilismsr is already working on this.

Since Nov 22, 2019.

question
Dominant language
Jupyter Notebook
Stars
4.8k
Forks
827
PR merge metrics
No merged PRs in 30d

Description

Hi! I'm using bootstrap to derive confidence interval for ORF. I notice that the bootstrap estimator relies on random sampling with replacement. This raises a concern with respect to ORF (forest-based) estimation. Because of sampling with replacement, it is likely that one single observation is sampled more than once for an ORF estimation process. This means that identical observations may be used for training the tree/forest/weights. Specifically, the identical observations will definitely go into the same leaf. This looks somehow wired, though I don't have a clear prediction on how this will influence estimating results.

I checked other forest-based methods, such as random forest, generalized random forest proposed by Athey et al. It seems that when growing trees repeatedly, random forest allows sampling either with or without replacement, while generalized random forest (causal forest) only allows sampling without replacement. As for ORF, I guess sampling without replacement is more suitable. Any suggestions on this? Thanks!

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.