Keyword only T0, T1 in NPIV
Open
@kbattocchi is already working on this.
Since Nov 20, 2019.
bug
- Dominant language
- Jupyter Notebook
- Stars
- 4.8k
- Forks
- 827
- PR merge metrics
- No merged PRs in 30d
Description
The T0, T1 arguments in effect should be keyword only. The NonparametricTwoStageLeastSquares overwrites the effect and does not have a *
https://github.com/microsoft/EconML/blob/57327b4df606d3a9a0dd476e67ae9caca02cbea0/econml/two_stage_least_squares.py#L183
This requires also adding a change in the test_bootstrap and in any other place in the tests that use T0 and T1 as position arguments.
https://github.com/microsoft/EconML/blob/57327b4df606d3a9a0dd476e67ae9caca02cbea0/econml/tests/test_bootstrap.py#L244
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.