py-why / py-why/EconML

DebiasedLasso and sample_var

Open
#166 0 comments 0 reactions 1 assignee View on GitHub

@moprescu is already working on this.

Since Nov 17, 2019.

bug
Dominant language
Jupyter Notebook
Stars
4.8k
Forks
827
PR merge metrics
No merged PRs in 30d

Description

The debiased lasso does not accept sample_var as a keyword hence every class like the SparseLinearDMLCateEstimator and SparseLinearDRLearner that are using it, do not really have valid inference when used with sample_weights not None (i.e. with data that represent summaries of multiple data points.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.