puzzle / puzzle/puzzle-shell

Fix tab order on desktop

Open
#44 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
TypeScript
Stars
7
Forks
3
Avg merge
21h 52m
Merged PRs (30d)
13

Description

Given the following example on desktop screen size:
https://puzzle.github.io/puzzle-shell/?path=/story/puzzle-shell-examples-content-app-with-search--default

Current tab order:

  1. Logo (if it has any link, which is not the case in the above example)
  2. Search input
  3. Menu actions (which are absolutely positioned over the topbar)
  4. Menu items (links "Fruit", "Vegetables" etc.)
  5. Any links in the content (not present in the above example)
  6. Footer links (not present in the above example)

Desired tab order:

  1. Logo
  2. Menu actions
  3. Menu items
  4. Search input
  5. Any links in the content
  6. Footer links

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked Storybook example at the provided URL and inspect the desktop shell's rendered tab sequence. Adjust the shell so focus moves from the logo to menu actions, menu items, the search input, content links, and footer links, then verify the sequence with keyboard navigation.

Written by the indexing model from the issue text.

Assessment

Tech stack
storybook, typescript
Domain
accessibility, frontend
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.