purescript / purescript/pursuit

S key shortcut doesn't trigger focus onto search bar when the current search returns only one page of results

Open
#426 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Haskell
Stars
174
Forks
47
PR merge metrics
No merged PRs in 30d

Description

The culprit seems to be the code for the "Load more results" button crashing, causing other javascript to not be executed.

A link to reproduce the issue: https://pursuit.purescript.org/search?q=NoResults

The error in the console: TypeError: link is null Pursuit.js:164:13

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Open the linked search result for “NoResults” and inspect Pursuit.js around line 164, where the console reports TypeError: link is null from the Load more results code. Confirm that the error occurs when only one page of results is shown, then verify that the S shortcut focuses the search bar and the console error is gone.

Written by the indexing model from the issue text.

Assessment

Tech stack
javascript
Domain
frontend, search
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.