puppetlabs / puppetlabs/puppetlabs-sqlserver
Paramter as_sysadmin_accounts does not behave in the same way as sql_sysadmin_accounts
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 5
- Forks
- 22
- Avg merge
- 19h 50m
- Merged PRs (30d)
- 4
Description
Describe the Bug
When passing an array or strings to as_sysadmin_accounts the output escapes each string that has been wrapped with quotes.
Expected Behavior
It should work in the same way as sql_sysadmin_accounts. Not escaping quotes when creating the setup.exe command line.
Steps to Reproduce
Steps to reproduce the behavior:
Pass an array of strings into the as_sysadmin_accounts parameter of the sql_instance resource, run puppet
Additional Context
I think the following commit was only applied to the sql_sysadmin_accounts parameters https://github.com/puppetlabs/puppetlabs-sqlserver/commit/fd3e772c40447016b70aa5d44a2077a72868778b it should also be applied to as_sysadmin_accounts
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start at the sql_instance resource and inspect how as_sysadmin_accounts and sql_sysadmin_accounts are handled. Review the referenced commit for the existing parameter behavior, reproduce the setup.exe command-line output with an array of quoted strings, and confirm both parameters produce equivalent quoting.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby, sql
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Active
- Clarity
- Mostly clear
- Newbie friendliness
- 72/100