puppetlabs / puppetlabs/puppetlabs-sqlserver
Specifying a SID value for SQL login creation
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 5
- Forks
- 22
- Avg merge
- 19h 50m
- Merged PRs (30d)
- 4
Description
Use Case
Having the ability to specify a SID value when creating a login of type SQL_LOGIN, as this will allow us to ensure that SIDs match across all servers for logins of this type. This is required when cloning databases between environments for the permissions to be reflected
Describe the Solution You Would Like
A parameter for the sqlserver::login resource that allows you to specify the SID value directly
Describe Alternatives You've Considered
We are looking at conditionally creating anything of type SQL_LOGIN via a sqlserver_tsql resource and string interpolation, only using sqlserver::login for WINDOWS_LOGIN entries. This should work, but is pretty suboptimal!
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
The issue names the sqlserver::login resource but no source file or test. Start by locating that resource and its SQL_LOGIN handling; done means a SID can be supplied directly for SQL_LOGIN and remains usable when databases are cloned.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- sql
- Domain
- databases
- Issue type
- Feature
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100