puppetlabs / puppetlabs/puppetlabs-sqlserver

3.3.0 update breaks execute SQL implementation

Open
#427 4 comments 2 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bugfix community
Dominant language
Ruby
Stars
5
Forks
22
Avg merge
19h 50m
Merged PRs (30d)
4

Description

lib/puppet_x/sqlserver/sql_connection.rb was updated in the last release to update to a newer version of the SQL Driver.

I don't have a massive problem with this, as the Native SQL driver used was out of date and no longer supported, however, the release notes for this release made no mention of the requirement change. Unfortunately the referenced driver is also out of date and the latest version 19, does not work with this change.

The change has also been hardcoded, so there is no way of overriding the default.

Please can you:

  1. Update the documentation to state that the MSOLEDBSQL driver is now required to use this module. You can use this chocolatey package for installation. but it must version 18.x or earlier.

More details on this driver can be found here however, it references version 19 by default.

  1. Mention that the current release does not support v19 of MSOLEDBSQL in the release notes and readme.

  2. Raise a item to allow overriding of the driver, that way we can use version 19 of the driver or later version if Microsoft bring out a new one; defaulting to this one.

Error below for reference:

OLE error code:800A0E7A in ADODB.Connection
      Provider cannot be found. It may not be properly installed.
    HRESULT error code:0x80020009
      Exception occurred. (corrective)

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with lib/puppet_x/sqlserver/sql_connection.rb at line 34, then review the README and release notes for the documented driver requirement. Confirm that MSOLEDBSQL 18.x or earlier is required and that version 19 is unsupported. Record the requirement and incompatibility in the documentation, and scope the requested driver override as a separate follow-up.

Written by the indexing model from the issue text.

Assessment

Tech stack
ruby, sql
Domain
databases, documentation
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.