puppetlabs / puppetlabs/puppetlabs-postgresql

postgis package logic is broken for EL8/EL9

Open
#1,522 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

community
Dominant language
Ruby
Stars
232
Forks
610
Avg merge
5d 23h
Merged PRs (30d)
4

Description

Describe the Bug

This is a followup issue for #1521 / #1519. There's some logic in manifests/params.pp to figure out the correct name for the postgis package:

      if $postgresql::globals::postgis_package_name {
        $postgis_package_name = $postgresql::globals::postgis_package_name
      } elsif $facts['os']['release']['major'] == '5' {
        $postgis_package_name = 'postgis'
      } elsif $postgis_version and versioncmp($postgis_version, '2') < 0 {
        $postgis_package_name = "postgis${package_version}"
      } else {
        $postgis_package_name = "postgis2_${package_version}"
      }

There's no matching package on EL8/EL9 (tested via https://pkgs.org/search/?q=postgis). Also there seems to be no suitable acceptance test to verify this is actually working.

Expected Behavior

Aa working postgresql installation on EL8/EL9 with postgis extension

Steps to Reproduce

Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'

Environment

  • Version [e.g. 1.27.0]
  • Platform [e.g. Ubuntu 18.04]

Additional Context

Add any other context about the problem here.

Contributor guide

Open the contributing guide

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start in manifests/params.pp and compare the existing package-name branches with EL8/EL9 package availability. Add or update an acceptance test for a working PostgreSQL installation with the PostGIS extension on EL8/EL9, and use it to verify the package logic.

Written by the indexing model from the issue text.

Assessment

Tech stack
postgresql
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.