puppetlabs / puppetlabs/puppetlabs-postgresql
Check if datatypes are reasonable
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 232
- Forks
- 610
- Avg merge
- 5d 23h
- Merged PRs (30d)
- 4
Description
Use Case
It seems like some datatypes could be more accurate
Describe the Solution You Would Like
correct datatypes if reasonable
Additional Context
example:
Variant[String[1], Stdlib::Port, Integer] $port = $postgresql::server::port,
Since Integer accepts all integers and String[1] all non empty strings the specialized Stdlib:Port will be without effect if it is a Pattern.
It does not make sense to have both Integer and Stdlib::Port since it is defined as Integer[0,65535] - should probably remove Integer from the variant unless it is possible to have a port that is > 65535.
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No file, test, or entry point is named. Start by locating the module's datatype declarations and reviewing the port example against the existing type definitions. Done means identifying and correcting datatype combinations that make specialized constraints ineffective, with the relevant project tests passing.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- postgresql
- Domain
- databases
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 30/100