puppetlabs / puppetlabs/puppetlabs-node_encrypt
Support Puppet Catalog Diff
Nobody has claimed this yet.
- Dominant language
- Ruby
- Stars
- 26
- Forks
- 21
- Avg merge
- 39m
- Merged PRs (30d)
- 1
Description
Every time node_encrypt is called it produces a different value. This isn't great when trying to use Puppet Catalog Diff
The best thought I've had so far is the function returning a sha1 hash if it detects catalog compilation caused by catalog diff.
Certificate extensions are available in the trusted facts, so maybe we could check these? That would work for the /puppet/v3/catalog endpoint without modifications to catalog-diff. Dunno if there's anyway a function can determine if the puppet 6.2+ certless endpoint was used.
@raphink Any better ideas?
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
No source file or test is named. Start by tracing how node_encrypt is called during catalog compilation and how trusted facts or certificate extensions expose the request context; compare the Puppet Catalog Diff /puppet/v3/catalog and Puppet 6.2+ certless catalog endpoints. Done means a documented, agreed approach for producing stable values during catalog diff without changing normal behavior.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- ruby
- Domain
- security
- Issue type
- Feature
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Needs clarification
- Newbie friendliness
- 25/100